Re: [PATCH] mm: fix balloon_page_movable() page->flags check

From: Rafael Aquini
Date: Tue Nov 27 2012 - 20:30:38 EST


On Tue, Nov 27, 2012 at 05:15:44PM -0800, Andrew Morton wrote:
> On Tue, 27 Nov 2012 22:34:10 -0200 Rafael Aquini <aquini@xxxxxxxxxx> wrote:
>
> > Do you want me to resubmit this patch with the changes you suggested?
>
> oh, I think I can reach that far. How's this look?
>

It looks great to me.

Just a small nitpick,
here __balloon_page_flags should be changed to page_flags_cleared too:
> @@ -109,18 +110,16 @@ static inline void balloon_mapping_free(
> /*
> * __balloon_page_flags - helper to perform balloon @page ->flags tests.
> *

Thanks!
--Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/