Re: [RFC][PATCH] fs: configfs: programmatically create config groups

From: Sebastian Andrzej Siewior
Date: Wed Nov 28 2012 - 03:15:20 EST


On 11/27/2012 05:23 PM, Michal Nazarewicz wrote:
On Tue, Nov 27 2012, Sebastian Andrzej Siewior wrote:
I don't want to push python on anyone but the removal magic is simply
straight forward: unlink the disk ports, rmdir luns, tpgt,â

How should a generic tool know what kind of actions are needed for given
function to be removed? If you ask me, there should be a way to unbind
gadget and unload all modules without any specific knowledge of the
functions. If there is no such mechanism, then it's a bad user
interface.

Well. You need only to remove the directories you created. An unbind
would be simply an unlink of the gadget which is linked to the udc.
All configurations remain so you can link it at a later point without
touching the configuration because it is as it was.

I understand the need for things that pop later like interfaceXX but
couldn't the user manually create them if he needs them?

I think the question is of information flow direction. If user gives
some information to the kernel, she should be the one creating any
necessary directories. But if the information comes from kernel to the
user, the kernel should create the structure.

Yes that is a point. But the "name" can go away if we use it in the
directory name. That is what other configfs user do. The same is true
for luns for instance. I just want to avoid adding features because we
do something different compared to every other configfs user.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/