Re: [PATCH v2] sp5100_tco: Add SB8x0 chipset support

[Paul Menzel]

Dear Takahisa,


as replied to ticket #43176 in Bugzilla thanks a lot for your work.


Am Freitag, den 16.11.2012, 00:23 +0900 schrieb Takahisa Tanaka:
> The current sp5100_tco driver only supports SP5100/SB7x0 chipset, doesn't
> support SB8x0 chipset, because current sp5100_tco driver doesn't know that the
> offset address for watchdog timer was changed from SB8x0 chipset.
> 
> The offset address of SP5100 and SB7x0 chipsets are as follows, quote from the
> AMD SB700/710/750 Register Reference Guide(Page 164) and the AMD SP5100

In English you leave a space before parentheses: â Guide (page 164) â

> Register Reference Guide(Page 166).

Dito.

>   WatchDogTimerControl 69h
>   WatchDogTimerBase0   6Ch
>   WatchDogTimerBase1   6Dh
>   WatchDogTimerBase2   6Eh
>   WatchDogTimerBase3   6Fh
> 
> In contrast, the offset address of SB8x0 chipset is as follows, quote from
> AMD SB800-Series Southbridges Register Reference Guide(Page 147).

Dito.

>   WatchDogTimerEn      48h
>   WatchDogTimerConfig  4Ch
> 
> So, In the case of SB8x0 chipset, sp5100_tco reads meaningless MMIO
> address(for example, 0xbafe00) from wrong offset address, and the following

Dito.

> message is logged.
> 
>    SP5100 TCO timer: mmio address 0xbafe00 already in use
> 
> With this patch, sp5100_tco driver supports SB8x0 chipset, and can avoid
> iomem resource conflict.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=43176
> Tested-by: Arkadiusz Miskiewicz <arekm@xxxxxxxx>
> Signed-off-by: Takahisa Tanaka <mc74hc00@xxxxxxxxx>
> 
> ---
> v1 -> v2
>  -Fix typo in module description and source code.
>  -Fix a bug that can't correctly determine the watchdog fired.
>  -Improve syslog messages.
>  -Truncate the commit log, because previous commit log is too long.

There are no too long commit messages. ;-)

> ---
>  drivers/watchdog/sp5100_tco.c | 321 +++++++++++++++++++++++++++++++++++-------
>  drivers/watchdog/sp5100_tco.h |  46 ++++--
>  2 files changed, 306 insertions(+), 61 deletions(-)

[â]

Tested-by: Paul Menzel <paulepanter@xxxxxxxxxxxxxxxxxxxxx>


Thanks,

Paul

Attachment: signature.asc
Description: This is a digitally signed message part