RE: [PATCH 1/1] regmap: Add support for continously numbered pagesacross regmap range

[Navada Kanyana, Mukund]

> -----Original Message-----
> From: Mark Brown [mailto:broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx]
> Sent: Wednesday, November 28, 2012 2:59 PM
> To: Navada Kanyana, Mukund
> Cc: Greg Kroah-Hartman; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/1] regmap: Add support for continously numbered
> pages across regmap range
> 
> On Wed, Nov 28, 2012 at 02:52:57PM +0530, Mukund Navada wrote:
> >   Page number in some devices increases across regmap ranges since the
> > selector register to choose the page remains the same. So in order to
> > write correct page number, the start_page_num is stored in
> > regmap_range_cfg.
> 
> I'm sorry but I can't understand what this is supposed to do.  The
> current paging code expects pages to be numbered continuously with no
> gaps.  Can you please clarify?
But the page number is expected to increase only till end of range. But in devices like TLV320AIC3256, the page number increases beyond range.

Example:

Pages 0 through Page 1 --> first register range for device configuration. Page 8 through Page 16 --> second range for DSP1 coefficient memory
Page 26 through Page 34 --> third range for DSP2 coefficient memory

Window length of each page is 128. So if we need to correctly write the page number in selector register for second range, start_page_num would be 8. If we did not have start_page_num, it would write 0 to selector register. 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/