Re: [PATCH 0/5] Alter steal time reporting in KVM

From: Michael Wolf
Date: Wed Nov 28 2012 - 13:43:21 EST


On 11/27/2012 05:24 PM, Marcelo Tosatti wrote:
On Mon, Nov 26, 2012 at 02:36:24PM -0600, Michael Wolf wrote:
In the case of where you have a system that is running in a
capped or overcommitted environment the user may see steal time
being reported in accounting tools such as top or vmstat.
The definition of stolen time is 'time during which the virtual CPU is
runnable to not running'. Overcommit is the main scenario which steal
time helps to detect.

Can you describe the 'capped' case?
In the capped case, the time that the guest spends waiting due to it having used its full allottment of time shows up as steal time. The way my patchset currently stands is that you would set up the
bandwidth control and you would have to pass it a matching value from qemu. In the future, it would
be possible to have something parse the bandwidth setting and automatically adjust the setting in the
host used for steal time reporting.

This can
cause confusion for the end user. To ease the confusion this patch set
adds the idea of consigned (expected steal) time. The host will separate
the consigned time from the steal time. The consignment limit passed to the
host will be the amount of steal time expected within a fixed period of
time. Any other steal time accruing during that period will show as the
traditional steal time.

---

Michael Wolf (5):
Alter the amount of steal time reported by the guest.
Expand the steal time msr to also contain the consigned time.
Add the code to send the consigned time from the host to the guest
Add a timer to allow the separation of consigned from steal time.
Add an ioctl to communicate the consign limit to the host.


arch/x86/include/asm/kvm_host.h | 11 +++++++
arch/x86/include/asm/kvm_para.h | 3 +-
arch/x86/include/asm/paravirt.h | 4 +--
arch/x86/include/asm/paravirt_types.h | 2 +
arch/x86/kernel/kvm.c | 8 ++---
arch/x86/kernel/paravirt.c | 4 +--
arch/x86/kvm/x86.c | 50 ++++++++++++++++++++++++++++++++-
fs/proc/stat.c | 9 +++++-
include/linux/kernel_stat.h | 2 +
include/linux/kvm_host.h | 2 +
include/uapi/linux/kvm.h | 2 +
kernel/sched/core.c | 10 ++++++-
kernel/sched/cputime.c | 21 +++++++++++++-
kernel/sched/sched.h | 2 +
virt/kvm/kvm_main.c | 7 +++++
15 files changed, 120 insertions(+), 17 deletions(-)

--
Signature

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/