Re: [dm-devel] [PATCH 2/3] dm raid1: add interface to set resyncspeed
From: Lars Marowsky-Bree
Date: Fri Nov 30 2012 - 06:59:12 EST
On 2012-11-22T14:27:52, Guangliang Zhao <gzhao@xxxxxxxx> wrote:
Hi Guangliang,
thanks for adding this. I think this approach is a good direction to
take, just one feedback:
> Add ioctl to control resync speed, userspace tool
> is dmsetup message, message format is:
> dmsetup message $device 0 "set $speed"
> e.g.
> dmsetup message /dev/dm-2 "set 12345"
I think this should be "set-max-resync-rate" or something; "set" is very
generic and not very extensible going forward, should the need arise.
Regards,
Lars
--
Architect Storage/HA
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 21284 (AG Nürnberg)
"Experience is the name everyone gives to their mistakes." -- Oscar Wilde
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/