Re: [RFC GIT PULL] scheduler fix for autogroups
From: Linus Torvalds
Date: Sat Dec 01 2012 - 17:03:25 EST
On Sat, Dec 1, 2012 at 1:44 PM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> You are not missing anything. That flag is my fault not Mike's:
> I booted the initial version of that patch but was unsure
> whether autogroups was enabled - it's a pretty transparent
> feature. So I figured that having that flag (but readonly) would
> give us this information definitely.
So what's the advantage of it being read-only at all?
Since the flag is clearly *used*, make it read-write, and then all my
objections go away (except for a slight worry that the dropping of
/proc/<pid>/autogroup_nice or whatever it is could break some odd
system app, but I don't worry *too* much about that).
Disabling autogroup is clearly something people might want, since the
code tests for it. So removing the flag entirely seems wrong too. But
if it exists, it should be writable. No?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/