Re: [net-next rfc v7 1/3] virtio-net: separate fields ofsending/receiving queue from virtnet_info
From: Michael S. Tsirkin
Date: Mon Dec 03 2012 - 06:16:00 EST
On Mon, Dec 03, 2012 at 01:15:01PM +0800, Jason Wang wrote:
> > > +
> > > + /* Work struct for refilling if we run low on memory. */
> > > + struct delayed_work refill;
> > I can't really see the justificaiton for a refill per queue. Just have
> > one work iterate all the queues if it happens, unless it happens often
> > (in which case, we need to look harder at this anyway).
> But during this kind of iteration, we may need enable/disable the napi
> regardless of whether the receive queue has lots to be refilled. This may add
> extra latency.
We are running from the timer, so latency is not a concern I think.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/