Re: [PATCH v2 3/4] uprobes/powerpc: Introduce routines for save/restorecontext

From: Suzuki K. Poulose
Date: Mon Dec 03 2012 - 10:48:25 EST

On 12/03/2012 08:45 PM, Ananth N Mavinakayanahalli wrote:
On Mon, Dec 03, 2012 at 08:39:35PM +0530, Suzuki K. Poulose wrote:
From: Suzuki K. Poulose <suzuki@xxxxxxxxxx>

Introduce routines for saving and restoring the context
befre/after the single step. No functional changes involved.

These will be extended later to save/restore more info about
the process once we replace the ptrace helpers.

Signed-off-by: Suzuki K. Poulose <suzuki@xxxxxxxxxx>
arch/powerpc/kernel/uprobes.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/kernel/uprobes.c b/arch/powerpc/kernel/uprobes.c
index bc77834..1a62353 100644
--- a/arch/powerpc/kernel/uprobes.c
+++ b/arch/powerpc/kernel/uprobes.c
@@ -52,6 +52,16 @@ int arch_uprobe_analyze_insn(struct arch_uprobe *auprobe,
return 0;

+static void uprobe_save_context_sstep(struct arch_uprobe_task *autask)
+ autask->saved_trap_nr = current->thread.trap_nr;
+static void uprobe_restore_context_sstep(struct arch_uprobe_task *autask)
+ current->thread.trap_nr = autask->saved_trap_nr;

Can't the two above be inline?
I had this discussion with Srikar and he was of the opinion that, we
should leave it as just static and let the compiler do the optimization.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at