RE: [PATCH v4 1/3] aerdrv: Trace Event for AER

From: Ortiz, Lance E
Date: Mon Dec 03 2012 - 14:58:55 EST


> > +/*
> > + * PCIe Advanced Error Reporting (AER) PCIE Report Error
>
> Why do you insist on keeping this convoluted compound name? What does
> "PCIe AER PCIe Report Error" even mean?
>
> This is not unreadable technical documentation but something people
> should actually understand. And it is simply a PCIe AER tracepoint. So
> why the h*ll not call it by its real name?

I will fix that.

>
> > + *
> > + * These events are generated when hardware detects a corrected or
> > + * uncorrected event on a pci express device. The event report has
>
> And you should stick to the same spelling for PCIe throughout the text,
> so choose one and use it everywhere.
>
Ok

>
> Also, you haven't addressed Mauro's comment about other bits in the
> spec
> which are not here. Why are you skipping them?

I missed that mail. I will address that.

Lance
èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸ ¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðà nÆàþY&—