Re: [linux-keystone] [PATCH v2] drivers: cma: fix addressing on PAE machines

From: Michal Nazarewicz
Date: Tue Dec 04 2012 - 08:07:58 EST

> On Monday 03 December 2012 09:16 PM, Vitaly Andrianov wrote:
>> This patch fixes a couple of bugs that otherwise impair CMA functionality on
>> PAE machines:
>> - alignment must be a 64-bit type when running on systems with 64-bit
>> physical addresses. If this is not the case, the limit calculation thunks
>> allocations down to an address range < 4G.
>> - The allocated range check is removed. On 32bit ARM kernel with LPAE
>> enabled the base may be allocated outside the fist 4GB of physical
>> memory (keystone SoC for example).

On Tue, Dec 04 2012, Santosh Shilimkar wrote:
> Any reason you have clubbed two fixes in one patch. Its better to keep
> the two fixes separate patches.

They are all related to the very same issue, and what the whole patch
does is change the type used to store physical addresses from unsigned
long to phys_addr_t. This is really a single change.

>> Signed-off-by: Vitaly Andrianov <vitalya@xxxxxx>
>> Signed-off-by: Cyril Chemparathy <cyril@xxxxxx>

Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, MichaÅ âmina86â Nazarewicz (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--

Attachment: pgp00000.pgp
Description: PGP signature