On Wed, Dec 5, 2012 at 5:52 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:On Wed, Dec 5, 2012 at 4:51 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:On Wed, Dec 5, 2012 at 4:36 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:On 12/05/2012 04:15 PM, Yinghai Lu wrote:
I don't see why that isn't the right fix. We copy the data into
boot_params early in the boot; that *is* the official copy as far as the
kernel is concerned.
So this patch very much seems like The Right Thing.
it moves boot_params from __initdata to data.
should be from __initdata to bss
and just for using pointer to setup_data.
should add setup_data pointer instead. so will not waste (4096 - 8) bytes.
I'm not following the whole discussion here, but my impression is that
what's in my -next branch is acceptable
If not, please explain further and provide a patch to fix it.