Re: Use PCI ROMs from EFI boot services

From: Yinghai Lu
Date: Thu Dec 06 2012 - 13:57:42 EST


On Thu, Dec 6, 2012 at 10:54 AM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:
> On Thu, Dec 06, 2012 at 10:26:01AM -0800, H. Peter Anvin wrote:
>
>> NAK on this bit:
>>
>> + if (boot_params.hdr.version < 0x0209)
>> + return 0;
>>
>> This field is kernel->bootloader documentation. If a nonmaching
>> value somehow leaks into the kernel, the kernel could either
>> panic("Bootloader written by moron") or it should clear some fields,
>> but littering the kernel with these kinds of tests is just plain
>> braindead.
>
> Dropping that should be fine. Bjorn, would you prefer a patch from me to
> do that?

the one : use pointer for setup_pci instead.

Attachment: pa_data_setup_pci.patch
Description: Binary data