Re: [PATCH 036/270] kbuild: Do not package /boot and /lib in maketar-pkg

From: Greg Kroah-Hartman
Date: Thu Dec 06 2012 - 15:17:20 EST


On Fri, Nov 30, 2012 at 02:19:49AM +0000, Ben Hutchings wrote:
> On Thu, 2012-11-29 at 17:38 -0800, Greg Kroah-Hartman wrote:
> > On Tue, Nov 27, 2012 at 02:26:27AM +0000, Ben Hutchings wrote:
> > > On Mon, 2012-11-26 at 14:55 -0200, Herton Ronaldo Krzesinski wrote:
> > > > 3.5.7u1 -stable review patch. If anyone has any objections, please let me know.
> > > >
> > > > ------------------
> > > >
> > > > From: Michal Marek <mmarek@xxxxxxx>
> > > >
> > > > commit fe04ddf7c2910362f3817c8156e41cbd6c0ee35d upstream.
> > > >
> > > > There were reports of users destroying their Fedora installs by a kernel
> > > > tarball that replaces the /lib -> /usr/lib symlink. Let's remove the
> > > > toplevel directories from the tarball to prevent this from happening.
> > > >
> > > > Reported-by: Andi Kleen <andi@xxxxxxxxxxxxxx>
> > > > Suggested-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> > > > Signed-off-by: Michal Marek <mmarek@xxxxxxx>
> > > > [ herton: dropped unrelated changes to arch/x86/Makefile and
> > > > scripts/Makefile.fwinst, which don't apply anyway on 3.5, see commit
> > > > 3ce9e53e788881da0d5f3912f80e0dd6b501f304 upstream ]
> > > > Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@xxxxxxxxxxxxx>
> > >
> > > This is missing from 3.4.
> >
> > I don't think it is needed, as 3ce9e53e788881da0d5f3912f80e0dd6b501f304
> > didn't go into 3.4, so all should be good for now.
>
> No, 3ce9e53e788881da0d5f3912f80e0dd6b501f304 was later and reverted
> unintended changes in fe04ddf7c2910362f3817c8156e41cbd6c0ee35d. You
> should probably combine the two.
>
> See these stable commits:
>
> 3.2: 0767530 kbuild: Do not package /boot and /lib in make tar-pkg
> 3.6: 4bb50fa kbuild: Do not package /boot and /lib in make tar-pkg
> 3.6: 0a7f602 kbuild: Fix accidental revert in commit fe04ddf

Ah, thanks, that makes more sense, I think I have it straightened out
now.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/