Re: [PATCH v2 0/3] gpio: twl4030: Correct status reporting for outputs

From: Linus Walleij
Date: Fri Dec 07 2012 - 03:09:37 EST

On Thu, Dec 6, 2012 at 11:52 AM, Peter Ujfalusi <peter.ujfalusi@xxxxxx> wrote:

> As Grant commneted on the first version:
> Introduce bitfields to cache the directionand output status of the pins so we
> can report them correctly.
> To do this I did some cleanup within the driver to get rid of the global
> variables and moved them under a private structure, changed the locking as well
> to protect the bitfield operation.
> As a last patch I added a note that the PWMA/B handling should not be in this
> driver at all.

This looks good to me:
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Since Grant was requesting the changes I'll let him decide to merge.

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at