Re: [PATCH RFT] regulator: 88pm8607: Update update_bit for BUCK2 in pm8607_set_voltage_sel

[Haojian Zhuang]

On Sun, Dec 9, 2012 at 11:41 AM, Axel Lin <axel.lin@xxxxxxxxxx> wrote:
> BUCK2 has the update_bit setting, but current code does not set update_bit
> in pm8607_set_voltage_sel.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
> ---
> Hi Haojian,
> I don't have the datasheet, can you check if this patch is correct or not?
> Thanks,
> Axel
>  drivers/regulator/88pm8607.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/88pm8607.c b/drivers/regulator/88pm8607.c
> index 2b55711..5c4879a 100644
> --- a/drivers/regulator/88pm8607.c
> +++ b/drivers/regulator/88pm8607.c
> @@ -236,6 +236,7 @@ static int pm8607_set_voltage_sel(struct regulator_dev *rdev, unsigned selector)
>                 return ret;
>         switch (info->desc.id) {
>         case PM8607_ID_BUCK1:
> +       case PM8607_ID_BUCK2:
>         case PM8607_ID_BUCK3:
>                 ret = pm860x_set_bits(info->i2c, info->update_reg,
>                                       1 << info->update_bit,
> --
> 1.7.9.5
>
>
>
It's unnecessary since BUCK2 is designed to control voltage of CP
domain. If CP wants to scale frequency,
it could change BUCK2. Linux won't run in CP side. It only runs in AP
side. So we don't need to control
BUCK2 in AP side.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/