Re: [PATCH v2 03/44] Add CONFIG_HAVE_64BIT_ALIGNED_STRUCT for taskstats

From: James Hogan
Date: Mon Dec 10 2012 - 05:22:22 EST


On 08/12/12 03:43, H. Peter Anvin wrote:
> On 12/05/2012 08:08 AM, James Hogan wrote:
>> On 64 bit architectures with no efficient unaligned access, taskstats
>> has to add some padding to a reply to prevent unaligned access warnings.
>> However this also needs to apply to 32 bit architectures with 64 bit
>> struct alignment such as metag (which has 64 bit memory accesses).
>
> Wait... 64-bit struct alignment on structures with only 32-bit members?
> That might be... interesting... in a number of places...

Hi,

I'll rewrite the description as it's a bit misleading. On metag 64bit
struct alignment is required when it contains 64bit members, not if it
only contains 32bit members. Although metag is a 32bit arch, it can do
64bit memory accesses which must be aligned.

Thanks for taking a look.

James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/