Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correctparent inode number

[Leon Romanovsky]

On Wed, Dec 12, 2012 at 7:05 AM, Fubo Chen <fubo.chen@xxxxxxxxx> wrote:
>
> On Wed, Dec 12, 2012 at 3:37 PM, Namjae Jeon <linkinjeon@xxxxxxxxx> wrote:
> > +       /* dot and dotdot dentries should have zero-value hash code */
> > +       if (!memcmp(name, ".", 1) || !memcmp(name, "..", 2))
> > +               return 0;
>
> That looks suspicious. If memcmp(name, "..", 2) == 0 then always
> memcmp(name, ".", 1) == 0. Why two tests ?
It is not the case vice versa, so you still need to do two checks.
You need to distinguish dot(.), dotdot(..) and something with dot at
the beginning (for example - .o)

>
> Fubo.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
Leon Romanovsky | Independent Linux Consultant
        www.leon.nu | leon@xxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/