Re: [PATCH v5 09/11] thp: lazy huge zero page allocation

From: Kirill A. Shutemov
Date: Wed Dec 12 2012 - 17:04:16 EST


On Wed, Dec 12, 2012 at 01:48:04PM -0800, H. Peter Anvin wrote:
> On 12/12/2012 01:30 PM, Andrew Morton wrote:
> >>
> >> I can rewrite the check to static_key if you want. Would it be better?
> >
> > The new test-n-branch only happens on the first read fault against a
> > thp huge page, yes? In which case it's a quite infrequent event and I
> > suspect this isn't worth bothering about.
> >
>
> Not to mention that flipping the static key is *incredibly* expensive.

I'm fine with current code.

--
Kirill A. Shutemov

Attachment: signature.asc
Description: Digital signature