Re: [TRIVIAL PATCH 16/26] x86: Convert print_symbol to %pSR

From: Joe Perches
Date: Wed Dec 12 2012 - 17:23:52 EST


On Wed, 2012-12-12 at 21:49 +0000, Luck, Tony wrote:
> > I think I'd go ahead and ACK this unless Tony has some comments. I'm not
> > happy about the two pr_emerg calls based on the conditional.
>
> As written the patch has the nice property of not making any changes to the
> console output (except to eliminate the possibility of interleaved output that
> the original code had).

Well, it does eliminate a trailing space when m->cs != KERNEL_CS.
That probably won't hurt anything, but...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/