Re: [TRIVIAL PATCH 16/26] x86: Convert print_symbol to %pSR
From: Joe Perches
Date: Thu Dec 13 2012 - 13:22:59 EST
On Wed, 2012-12-12 at 23:45 +0100, Borislav Petkov wrote:
> On Wed, Dec 12, 2012 at 02:23:59PM -0800, Joe Perches wrote:
> > On Wed, 2012-12-12 at 21:49 +0000, Luck, Tony wrote:
> > > > I think I'd go ahead and ACK this unless Tony has some comments. I'm not
> > > > happy about the two pr_emerg calls based on the conditional.
> > >
> > > As written the patch has the nice property of not making any changes to the
> > > console output (except to eliminate the possibility of interleaved output that
> > > the original code had).
> > Well, it does eliminate a trailing space when m->cs != KERNEL_CS.
> > That probably won't hurt anything, but...
> Yeah, that won't be an issue. So let's take it as is, as Tony suggests.
Hi again Boris.
I should mention one more thing.
m->ip is a u64 so, when compiling x86-32, there's a new warning
"cast to pointer from integer of different size". This isn't new
different behavior, just a new warning. The previous print_symbol
took a ulong and the u64 was silently truncated.
arch/x86/kernel/cpu/mcheck/mce.c: In function âprint_mceâ:
arch/x86/kernel/cpu/mcheck/mce.c:246:4: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
If appropriate, the code could be changed to
(void *)(unsigned long)m->ip
to shut the compiler up.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/