Re: [PATCH 00/26] AIO performance improvements/cleanups, v2

[Jens Axboe]

On 2012-12-15 11:36, Kent Overstreet wrote:
>> Knock yourself out - I already took a quick look at it, and conversion
>> should be pretty simple. It's the mtip32xx driver, it's in the kernel. I
>> would suggest getting rid of the ->async_callback() (since it's always
>> bio_endio()) since that'll make it cleaner.
> 
> Just pushed my conversion - it's untested, but it's pretty
> straightforward.

You forgot a batch_complete_init(). With that, it works. Single device
is ~1050K now, so still slower than jaio without batching (which was
~1220K).  But it's an improvement over kaio-dio, which was roughly ~930K
IOPS.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/