Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature availablefrom userspace

From: Hiraku Toyooka
Date: Mon Dec 17 2012 - 05:52:33 EST


(12/15/2012 02:08 AM), Steven Rostedt wrote:
On Fri, 2012-12-07 at 11:07 +0900, Hiraku Toyooka wrote:
Hi, Steven,

(2012/11/30 23:17), Steven Rostedt wrote:
[snip]
>
> Actually, I would have:
>
> status\input | 0 | 1 | else |
> --------------+------------+------------+------------+
> not allocated |(do nothing)| alloc+swap | EINVAL |
> --------------+------------+------------+------------+
> allocated | free | swap | clear |
> --------------+------------+------------+------------+
>
> Perhaps we don't need to do the clear on swap, just let the trace
> continue where it left off? But in case we should swap...
>

I think we don't need the clear on swap too.
I'll update my patches like this table.

> There's a fast way to clear the tracer. Look at what the wakeup tracer
> does. We can make that generic. If you want, I can write that code up
> too. Hmm, maybe I'll do that, as it will speed things up for
> everyone :-)
>


BTW, any update on this? I really like to get this into 3.9.


I'm applying your review comment and rebasing now. So, I'll post the
updated patch series in a few days.

Thanks,
Hiraku Toyooka

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/