Re: [PATCH 3.7.0 3/9] i82975x_edac.c: cleanup debug code

[Mauro Carvalho Chehab]

Em Sun, 16 Dec 2012 02:10:39 +0530
Arvind R <arvino55@xxxxxxxxx> escreveu:

> Subject: [PATCH 3.7.0 3/9] i82975x_edac.c: cleanup debug code
> 
> modify debug levels to sane levels. Also move random debug code
> into CONFIG_EDAC_DEBUG sections.
> Signed-off-by: Arvind R. <arvino55@xxxxxxxxx>
> ---
>  i82975x_edac.c |  171 +++++++++++++++++++++++-------------------
>  1 file changed, 97 insertions(+), 74 deletions(-)
> 
> --- a/drivers/edac/i82975x_edac.c	2012-12-15 20:18:24 +0530
> +++ b/drivers/edac/i82975x_edac.c	2012-12-15 20:17:58 +0530
...
> @@ -551,11 +583,11 @@ static int i82975x_probe1(struct pci_dev
>  	layers[1].is_virt_csrow = false;
>  	mci = edac_mc_alloc(0, ARRAY_SIZE(layers), layers, sizeof(*pvt));
>  	if (!mci) {
> +		edac_dbg(0, "MC%d failed mc_alloc\n", dev_idx);
>  		rc = -ENOMEM;
>  		goto fail1;

Please remove the two last lines. There's no reason why it a driver 
should bail out just because debug is enabled.


Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/