Re: [PATCH] checkpatch: Warn on #include <uapi/...

From: Joe Perches
Date: Tue Dec 18 2012 - 14:52:36 EST


On Tue, 2012-12-18 at 19:17 +0000, David Howells wrote:
> Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> > + if ($path =~ "^uapi/") {
> > + ERROR("UAPI_INCLUDE",
> > + "#include should not start with uapi/\n" . $herecurr);
> > }
>
> But does this limit the check only to headers in uapi/ directories?

No. I'm confused, I believe your example was:

arch/powerpc/include/asm/kvm_para.h
@@ -16,77 +16,11 @@
*
* Authors: Hollis Blanchard <hollisb@xxxxxxxxxx>
*/
-
#ifndef __POWERPC_KVM_PARA_H__
#define __POWERPC_KVM_PARA_H__

-#include <linux/types.h>
+#include <uapi/asm/kvm_para.h>

---------------

What do you want this to check?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/