Re: [PATCH] scripts: add checkmaintainers.py

[Joe Perches]

On Tue, 2012-12-18 at 21:31 +0100, Borislav Petkov wrote:
> On Tue, Dec 18, 2012 at 11:34:41AM -0800, Joe Perches wrote:
> > If no patch is attached, you should get
> >
> > ERROR: Does not appear to be a unified-diff format patch
> 
> Well, it needs to handle the case where a patch simply and only renames
> a file.
> 
> Then, even if a patch follows:
> 
> diff --git a/README b/README.old
> similarity index 99%
> rename from README
> rename to README.old
> index a24ec89ba442..b0a7aa56c3cc 100644
> --- a/README
> +++ b/README.old
> @@ -1,3 +1,6 @@
> +TEST
> +
> +
>          Linux kernel release 3.x <http://kernel.org/>
>  
>  These are the release notes for Linux version 3.  Read them carefully,
> --
> 
> it says:
> 
> $ git diff --cached HEAD -- | ./scripts/checkpatch.pl --strict -
> Must be run from the top-level dir. of a kernel tree
> 
> If I comment out the following hunk:
> 
>         if (!defined $root) { 
>                 print "Must be run from the top-level dir. of a kernel tree\n";
>                 exit(2);
>         }
> 
> then it works, albeit with a bunch of warnings:
> 
> Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1558.
> Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1558.
> Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304.
> Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304.
> Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304.
> Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304.
> Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304.
> Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304.
> CHECK: Patch renames README to README.old, update MAINTAINERS?

You renamed README which is one of the filenames used
when checkpatch verifies the top-level dir kernel tree.

Don't do that, README is a required filename.

Try another file in drivers or somewhere other than root.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/