Re: [PATCH 6/6] Add 32 bit VDSO support for 32 and 64 bit kernels

From: H. Peter Anvin
Date: Tue Dec 18 2012 - 17:24:26 EST


On 12/18/2012 12:37 PM, Andy Lutomirski wrote:

There is no introduce of new fix address. There are still there for
x86_64. If this will currently not a major problem on this architecture
than it will not for x86_32 too.

Not necessarily true. On x86-64 (non-compat) the fixmap address is in
kernel space (high bit set), so it can't conflict with anything in
user space. On true 32-bit mode, the same applies. In compat mode,
the fixed address is in *user* space and might conflict with existing
uses.


The other bit is that the fixmap isn't actually fixed on 32 bits, which creates its own set of problems. As such, I really would prefer a properly PIC solution.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/