Re: [PATCH] rtc-pcf8523: Add low battery voltage support

From: Thierry Reding
Date: Wed Dec 19 2012 - 10:19:39 EST


On Wed, Dec 19, 2012 at 04:10:54PM +0100, Jesper Nilsson wrote:
> On Wed, Dec 19, 2012 at 03:42:26PM +0100, Thierry Reding wrote:
> > On Wed, Dec 19, 2012 at 03:04:56PM +0100, Jesper Nilsson wrote:
[...]
> > > + .read_vl = pcf8523_rtc_read_vl,
> >
> > What tree is this based on? None of the trees I have contains .read_vl
> > in rtc_class_ops.
>
> Hm, I've tested this against a local 3.4 kernel since that is what my
> device had, I didn't realize that we already had some local changes for
> the voltage low stuff.
>
> I'm guessing the right way is to do it as the pcf8563 in the mainline kernel,
> I'll respin my patch and resend.

From a quick search through the mainline kernel history, there's no
trace of this field.

Thierry

Attachment: pgp00000.pgp
Description: PGP signature