Re: [PATCH v6 02/27] x86, mm: make pgd next calculation consistentwith pud/pmd

From: Borislav Petkov
Date: Wed Dec 19 2012 - 15:48:50 EST


On Tue, Dec 18, 2012 at 07:37:14PM -0800, Yinghai Lu wrote:
> update to :
>
> ---
> Subject: [PATCH] x86, mm: make pgd next calculation consistent with pud/pmd
>
> Just like the way we calculate next for pud and pmd, aka
> round down and add size.
>
> also remove not needed next checking, just pass end with phys_pud_init.
>
> pyhs_pud_init() uses PTRS_PER_PUD to stop its loop early so it could handle
> big end properly.

Almost there, let's merge the last two sentences:

"Also, do not boundary-check 'next' but pass 'end' down to
phys_pud_init() instead because the loop in there terminates at
PTRS_PER_PUD and thus can handle a possibly bigger 'end' properly."

Thanks.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/