Re: [PATCH v2] gpio: add TS-5500 DIO blocks support

[Vivien Didelot]

Hi Grant,

> Please take a look at either send me a follow-on patch to convert it
> to use gpio-generic, or tell my why gpio-generic isn't appropriate here.

The gpio-generic driver is not appropriate here because Technologic Systems
x86-based platforms do not use a typical GPIO implementation. 
To name a few specificities:
- The GPIOs are available through ioport and not iomem
- There are input-only/output-only/input-output lines on the same block
- The number of GPIOs differs between blocks (currently 11, 13 and 14 pins)
- A single bit in a control register drives the direction of 4 input/output
  lines, while the register's other bits have different functions.

IMHO these considerations justify a specific GPIO driver to support these
Technologic Systems pin blocks.

Regards,
Vivien
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/