Re: [PATCH] mm: compaction: count compaction events only ifcompaction is enabled

From: Mel Gorman
Date: Thu Dec 20 2012 - 05:52:12 EST


On Thu, Dec 20, 2012 at 11:21:34AM +0100, Jiri Kosina wrote:
> On configs which have CONFIG_CMA but no CONFIG_COMPACTION,
> isolate_migratepages_range() and isolate_freepages_block() must not
> account for COMPACTFREE_SCANNED and COMPACTISOLATED events (those
> constants are even undefined in such case, causing a build error).
>
> Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>

Minchan has a similar patch in the works that defines count_compact_events()
similar to count_vm_numa_events(). It just needs a small correction. The
fixed version would avoid having an #ifdef in the middle of the function
which is cosmetically a bit nicer.

--
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/