Re: [PATCH] cgroup: remove redundant check

From: Tejun Heo
Date: Thu Dec 20 2012 - 14:18:16 EST


On Thu, Dec 20, 2012 at 02:11:31PM -0500, Sasha Levin wrote:
> We already know that 'event' is non-NULL, remove the redundant check.
>
> Signed-off-by: Sasha Levin <sasha.levin@xxxxxxxxxx>

I don't know. I kinda like that test there. It's not an error path
and tearing down everything which could have been allocated. If the
test not being used is bothering, convert return -ENOMEM to goto fail?

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/