Re: [RFC PATCH 4/4] ext4: Fix an incorrect comment about i_mutex

From: Jan Kara
Date: Thu Dec 20 2012 - 18:42:41 EST


On Thu 20-12-12 15:10:12, Andy Lutomirski wrote:
> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
The patch looks good. You can add:
Reviewed-by: Jan Kara <jack@xxxxxxx>

BTW: The right person for this patch is ext4 maintainer:
"Theodore Ts'o" <tytso@xxxxxxx>
Since this is completely independent of anything else in this series,
just submit the patch to him. Thanks!

Honza
> ---
> fs/ext4/fsync.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
> index be1d89f..8c15642 100644
> --- a/fs/ext4/fsync.c
> +++ b/fs/ext4/fsync.c
> @@ -113,8 +113,6 @@ static int __sync_inode(struct inode *inode, int datasync)
> *
> * What we do is just kick off a commit and wait on it. This will snapshot the
> * inode to disk.
> - *
> - * i_mutex lock is held when entering and exiting this function
> */
>
> int ext4_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
> --
> 1.7.11.7
>
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/