Re: [PATCH] ksm: make rmap walks more scalable

[Hugh Dickins]

On Fri, 21 Dec 2012, Petr Holasek wrote:
> On Thu, 20 Dec 2012, Sasha Levin wrote:
> > On 12/20/2012 05:37 PM, Hugh Dickins wrote:
> > > 
> > > To stop these oopses in get_mergeable_page (inlined in
> > > unstable_tree_search_insert) you need the patch I showed on
> > > Tuesday, which I hope he'll merge in for his v6.  That doesn't fix
> > > all of the problems, but hopefully all that you'll encounter before
> > > I've devised a fix for the separate stale stable_nodes issue.
> > 
> > My bad! I thought that this is the finalized version of the patch from
> > Tuesday and was surprised when the oops was still there :)
> > 
> > fwiw I'll use this to report that I'm not seeing any unexpected behaviour
> > with this patch applied.

Thanks, Sasha.

> 
> Hugh, big thanks for your Tuesday fix, I am not able to reproduce reported
> oops any more. I will continue with testing overnight and submit v6 version
> tomorrow if there won't be any problem.

Great, thank you Petr.

> 
> Should I also add [PATCH] ksm: make rmap walks more scalable into v6 or
> can I rely on it?

No, this rmap walks patch is entirely independent of your changes,
and already picked up by Linus into his tree for rc1.

By all means test with it in, or out, but don't fold it into your v6:
Andrew's mmotm posted just now has it already in too.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/