Re: 3.8 NFS build breakage with !CONFIG_NFS_FSCACHE

From: Borislav Petkov
Date: Fri Dec 21 2012 - 03:33:02 EST


On Fri, Dec 21, 2012 at 11:14:21AM +0530, Vineet Gupta wrote:
> Hi David,
>
> Not sure if this was report/fixed already - but as of today's Linus tree
> (tip has commit 96680d2), I'm seeing a build breakage due to a trivial
> missing def for nfs_fscache_wait_on_invalidate.
>
> Following fixes it for me.
>
> diff --git a/fs/nfs/fscache.h b/fs/nfs/fscache.h
> index 277b027..4ecb766 100644
> --- a/fs/nfs/fscache.h
> +++ b/fs/nfs/fscache.h
> @@ -222,6 +222,7 @@ static inline void nfs_readpage_to_fscache(struct
> inode *inode,
>
>
> static inline void nfs_fscache_invalidate(struct inode *inode) {}
> +static inline void nfs_fscache_wait_on_invalidate(struct inode *inode) {}

I see the same thing here. Please write a proper patch and quote the
build error in the commit message:

fs/nfs/inode.c: In function ânfs_invalidate_mappingâ:
fs/nfs/inode.c:887:2: error: implicit declaration of function ânfs_fscache_wait_on_invalidateâ [-Werror=implicit-function-declaration]

Thanks.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/