Re: [RFC PATCH 6/6] uretprobes: register() and unregister()implementation

From: Oleg Nesterov
Date: Sat Dec 22 2012 - 11:37:51 EST


On 12/21, Anton Arapov wrote:
>
> +int uretprobe_register(struct inode *inode, loff_t offset, struct uprobe_consumer *uc)
> +{
> + return __uprobe_register(inode, offset, uc, true);
> +}
> ...
> +
> +void uretprobe_unregister(struct inode *inode, loff_t offset, struct uprobe_consumer *uc)
> +{
> + struct uprobe *uprobe;
> +
> + uprobe = find_uprobe(inode, offset);
> + if (!uprobe)
> + return;
> +
> + down_write(&uprobe->register_rwsem);
> + __uprobe_unregister(uprobe, uc, true);
> + up_write(&uprobe->register_rwsem);
> +
> put_uprobe(uprobe);
> }

See my reply to 3/6. So far I think that we do not need
uretprobe_register/unregister at all.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/