Re: [PATCH 08/25] thinkpad_acpi: don't use [delayed_]work_pending()

From: Henrique de Moraes Holschuh
Date: Sat Dec 22 2012 - 18:55:07 EST


On Fri, 21 Dec 2012, Tejun Heo wrote:
> There's no need to test whether a (delayed) work item in pending
> before queueing, flushing or cancelling it. Most uses are unnecessary
> and quite a few of them are buggy.
>
> Remove unnecessary pending tests from thinkpad_acpi. Only compile
> tested.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Henrique de Moraes Holschuh <ibm-acpi@xxxxxxxxxx>
> Cc: ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: platform-driver-x86@xxxxxxxxxxxxxxx

Acked-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>

> ---
> Please let me know how this patch should be routed. I can take it
> through the workqueue tree if necessary.

It will not clash with anything I know of, so feel free to route it
through the workqueue tree.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/