Re: [Suggestion] drivers/staging/tidspbridge: pr_err and pr_debug foruninitialized buffer (name buf not initialized).

From: Omar Ramirez Luna
Date: Mon Dec 24 2012 - 09:26:21 EST


Hi,

On Thu, Dec 13, 2012 at 7:30 PM, Chen Gang <gang.chen@xxxxxxxxxxx> wrote:
> also another suggestions:
> I built ti otmap with ti dsp bridge by arm cross-compiler under i386 platform.
> the version tag is next-20121213
> I met 2 compiling issues.
>
> a: module dependency:
> Multifunction device drivers --> Texas Instruments TWL/4030/TWL5030.... is required for TI OTMAP.
> it need depend on CONFIG_REGMAP (maybe also inculde CONFIG_REGMAP*)
> if CONFIG_REGMAP* not defined, building will be failed.

This is not related to tidspbridge, I sent a patch anyway as it looks
to be a valid build dependency bug.

> b: version merging issue:
> in drivers/staging/tidspbridge/core/_tiomap.h
> need use "#include <mach-omap2/cm3xxx.h>" instead of "#include <mach-omap2/cm2xxx_3xxx.h>"
> the macro OMAP3430_CM_AUTOIDLE_PLL has already move from cm2xxx_3xxx.h to cm3xxx.h.
> (it seems arch/arm/mach-omap2/ is not a suitable place for including, but we have to)
> if not change, compiling will be failed.

Done.

Cheers,

Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/