Re: [PATCH 17/25] wm97xx: don't use [delayed_]work_pending()

From: Mark Brown
Date: Mon Dec 24 2012 - 11:18:22 EST


On Sun, Dec 23, 2012 at 01:54:50AM -0800, Dmitry Torokhov wrote:

> This is not 100% equivalent transformation as now we schedule first and
> disable IRQ later... Anyway, I think the driver shoudl be converted to
> threaded IRQ instead. Mark, does the patch below make any sense to you?

I'm a bit nervous about the fact that currently both the pen down IRQ
and the coordinate read are pushed through a single workqueue so are
serialised but after your patch they'll be split into the IRQ thread and
the workqueue. It *should* be fine but I'd have to sit there and study
it to convince myself that it's safe.

Attachment: signature.asc
Description: Digital signature