Re: [Suggestion] drivers/staging/tidspbridge: pr_err and pr_debug foruninitialized buffer (name buf not initialized).

From: Omar Ramirez Luna
Date: Wed Dec 26 2012 - 01:28:55 EST


On Tue, Dec 25, 2012 at 7:56 PM, Chen Gang <gang.chen@xxxxxxxxxxx> wrote:
> 于 2012年12月24日 22:26, Omar Ramirez Luna 写道:
>>> b: version merging issue:
>>> > in drivers/staging/tidspbridge/core/_tiomap.h
>>> > need use "#include <mach-omap2/cm3xxx.h>" instead of "#include <mach-omap2/cm2xxx_3xxx.h>"
>>> > the macro OMAP3430_CM_AUTOIDLE_PLL has already move from cm2xxx_3xxx.h to cm3xxx.h.
>>> > (it seems arch/arm/mach-omap2/ is not a suitable place for including, but we have to)
>>> > if not change, compiling will be failed.
>
> also please help checking this issue, thanks.

I also sent a patch for this:

http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg82565.html

However, I just saw this one which was sent 6 days ago:

https://patchwork.kernel.org/patch/1895081/

The latter includes the new header file, mine just the definitions
needed, any approach is fine by me as they both fix the compile break.

Cheers,

Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/