Re: [PATCH V2] rtc: add RTC driver for TPS6586x

[Marc Dietrich]

On Thursday 27 December 2012 20:29:14 Laxman Dewangan wrote:
> On Thursday 27 December 2012 08:26 PM, Marc Dietrich wrote:
> > Hi Laxman,
> > 
> > On Friday 21 December 2012 20:42:28 you wrote:
> >> +
> >> +	/* Set epoch start as 00:00:00:01:01:2000 */
> >> +	rtc->epoch_start = mktime(2000, 1, 1, 0, 0, 0);
> > 
> > any reason why you hard coded it to 2000? All boards I know use 2009, so
> > with this patch, everyone needs to set his clock again.
> 
> No specific reason. If 2009 should be default then I can push patch to
> set it as 2009.

At least myself would appreciate this.

Stephen said on IRC, that this could be configurable via a property node from 
device tree (and also the IRQ which now comes from platform_data). Maybe this 
can be added later on. I really like to see this driver in mainline now.

You can also add a "Tested-By: Marc Dietrich <marvin24@xxxxxx>"

Thanks

Marc

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/