Re: [PATCH RESEND 4] ARM: plat-versatile: move secondary CPU startupinto cpuinit

From: Christoffer Dall
Date: Sat Dec 29 2012 - 23:09:35 EST


On Tue, Dec 18, 2012 at 3:42 AM, Claudio Fontana
<Claudio.Fontana@xxxxxxxxxx> wrote:
>
> Using __CPUINIT instead of __INIT puts the secondary CPU startup code
> into the "right" section: it will not be freed in hotplug configurations,
> allowing hot-add of cpus, while still getting freed in non-hotplug configs.
>
> Tested successfully on Fast-Models and on Arndale for VCPU hotplug.

not quite sure how testing on Arndale verifies this change?

>
> Signed-off-by: Claudio Fontana <claudio.fontana@xxxxxxxxxx>
> Tested-by: Claudio Fontana <claudio.fontana@xxxxxxxxxx>
>
> diff --git a/arch/arm/plat-versatile/headsmp.S b/arch/arm/plat-versatile/headsmp.S
> index dd703ef..19fe180 100644
> --- a/arch/arm/plat-versatile/headsmp.S
> +++ b/arch/arm/plat-versatile/headsmp.S
> @@ -11,7 +11,7 @@
> #include <linux/linkage.h>
> #include <linux/init.h>
>
> - __INIT
> + __CPUINIT
>
> /*
> * Realview/Versatile Express specific entry point for secondary CPUs.
> --
> 1.7.12.1
>

Otherwise looks ok to me (not guaranteeing that cpu hotplug will
magically work for KVM using this change though).

-Christoffer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/