Re: [PATCH,staging/speakup] Prefix externally-visible symbols

From: Greg Kroah-Hartman
Date: Tue Jan 01 2013 - 20:17:15 EST

On Tue, Jan 01, 2013 at 11:52:57PM +0100, Samuel Thibault wrote:
> This prefixes all externally-visible symbols of speakup with "spk_".
> (or makes static some of them which do not actually need to be
> externally-visible)

Care to break this up into smaller pieces? Like one for the variables
that should just be static? And then the other bits?

Also, I think you just changed user-visable variables/sysfs files, which
isn't acceptable. Be careful about that when you resend.


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at