Re: [PATCH,staging/speakup] Prefix externally-visible symbols

From: Samuel Thibault
Date: Tue Jan 01 2013 - 20:38:06 EST

Greg Kroah-Hartman, le Tue 01 Jan 2013 17:17:22 -0800, a écrit :
> On Tue, Jan 01, 2013 at 11:52:57PM +0100, Samuel Thibault wrote:
> > This prefixes all externally-visible symbols of speakup with "spk_".
> > (or makes static some of them which do not actually need to be
> > externally-visible)
> Care to break this up into smaller pieces? Like one for the variables
> that should just be static? And then the other bits?

Done so.

> Also, I think you just changed user-visable variables/sysfs files, which
> isn't acceptable. Be careful about that when you resend.

Oops, I thought these were variable references, but it's actually done
through callbacks indeed. Fixed.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at