Re: [PATCH] epoll: prevent missed events on EPOLL_CTL_MOD
From: Eric Dumazet
Date: Wed Jan 02 2013 - 17:08:53 EST
On Wed, 2013-01-02 at 19:32 +0000, Eric Wong wrote:
> That modification in ep_send_events_proc() is protected by ep->mtx
> (as is ep_modify()), though. Maybe there are other places, but I
> don't see it.
Yes, and using a mutex for protecting this field while its read from
interrupt context (so without mutex synch help) is why there were races.
Some users rely on barriers included in spin_lock/spin_unlock, others in
explicit barriers, or before your patch pure luck.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/