Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

From: Tejun Heo
Date: Wed Jan 02 2013 - 21:29:05 EST


Hello, Rusty.

On Thu, Jan 03, 2013 at 11:17:11AM +1030, Rusty Russell wrote:
> > So, I guess this currently is caught in a place which isn't here or
> > there. I'm pretty skeptical whether it makes sense to bother about
> > static usages tho. Can I keep them for static ones?
>
> I didn't realize that cpuset_attach was a fastpath. If it is, put a

It isn't a hot path. It's just a bit nasty to have to allocate them
separately.

> static there and I'll fix turn it into a bitmap when I need to.
> Otherwise, please don't change the code in the first place.

So, the plan to drop cpumask_t is still on? If so, I'll leave
cpumask_var_t.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/