Re: [PATCH 1/1] arm :omap :DMA: fix a bug on reserving the omap SDMAchannels

From: R Sricharan
Date: Thu Jan 03 2013 - 02:29:02 EST


On Sunday 30 December 2012 02:13 AM, ahemaily@xxxxxxxxx wrote:
From: ahemaily <ahemaily@xxxxxxxxx>

The variable dma_lch_count used for comparison (omap_dma_reserve_channels <= dma_lch_count)
before it initialized to the value from omap_dma_dev_attr : d->lch_count.

I change the place of dma_lch_count initialization to be before the comparison.

Signed-off-by: Abdelrahman Hemaily <ahemaily@xxxxxxxxx>
arch/arm/plat-omap/dma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index c76ed8b..cb3e321 100644
--- a/arch/arm/plat-omap/dma.c
+++ b/arch/arm/plat-omap/dma.c
@@ -2014,12 +2014,12 @@ static int __devinit omap_system_dma_probe(struct platform_device *pdev)

d = p->dma_attr;
errata = p->errata;
+ dma_lch_count = d->lch_count;
if ((d->dev_caps & RESERVE_CHANNEL) && omap_dma_reserve_channels
&& (omap_dma_reserve_channels <= dma_lch_count))
d->lch_count = omap_dma_reserve_channels;

- dma_lch_count = d->lch_count;
By removing this line, you are effectively not assigning
d->lch_count after reserving. So the patch should only change
dma_lch_count in the above "if statement" to d->lch_count


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at