Re: [PATCH -v2 03/26] x86: pageattr-test: remove srandom32 call

From: H. Peter Anvin
Date: Thu Jan 03 2013 - 12:35:41 EST

On 01/03/2013 04:18 AM, Akinobu Mita wrote:
pageattr-test calls srandom32() once every test iteration.
But calling srandom32() after late_initcalls is not meaningfull.
Because the random states for random32() is mixed by good random numbers
in late_initcall prandom_reseed().

So this removes the call to srandom32().

Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
Cc: x86@xxxxxxxxxx

No change from v1

Acked-by: H. Peter Anvin <hpa@xxxxxxxxx>

... for this and the other patch. Do you need me to pick it up or are you pushing this directly as part of your bigger patchset?

H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at