Re: [RFC PATCH 1/2] efi: Make 'efi_enabled' a function to query EFIfacilities
From: H. Peter Anvin
Date: Thu Jan 03 2013 - 12:42:15 EST
On 01/03/2013 05:18 AM, Matt Fleming wrote:
A machine's EFI facilities are naturally represented by a bitfield.
Nitpick: what you have here is a bitmask, not a bitfield. This is good,
because bitfields are generally frowned upon in a Linux kernel context,
but you may want to revise the description.
Other than that, looks good to me.
Acked-by: H. Peter Anvin <hpa@xxxxxxxxxxxxxxx>
-hpa (who is still on vacation)
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/