> +/*of System MMU
> + * Descriptions of Device Tree node for System MMU
> + *
> + * A System MMU should be described by a single tree node.
> + *
> + * A System MMU node should have the following properties:
> + * - reg: tuples of the base address and the size of the IO region
> + * - compatible: it must be "samsung,exynos-sysmmu".
I think this compatible property is too generic. It should include
name in it, e.g. samsung,exynos4210-sysmmu. Please refer to this thread
http://www.spinics.net/lists/linux-omap/msg83512.html, which discusses
Ok, I got the point. BTW , I think this will cause adding a
compatibility property whenever a SoC is released even though it has
completely sameSystem MMU. Is it inevitable?
> + * - interrupt-parent = specify if the interrupt of System MMU isgenerated by> + * interrupt combiner or interrupt controller.
> + * - interrupts: tuples of interrupt numbers. a tuple has 2 elements if
> + * @interrupt-parent is '<&combiner>', 3 elements otherwise.
It's probably enough to say that format of the interrupts property is
the interrupt controller used.
I agree that :)
> + *the System
> + * 'mmuname', 'reg' and 'interrupts' properties can be an array if
> + * MMU driver controls several number of System MMUs at the sametime. Note that> + * the number of elements in those three properties must be the same.
It might be useful to provide some example here.
examples are there in Documentations directory.
> + * The following properties are optional:
> + * - mmuname: name of the System MMU for debugging purpose
Not sure if it is something that is supposed to be included in FDT. You
probably derive it from the 'compatible' property, if it is really
needed. The device
tree bindings should not be treated as direct replacement for platform
actually it is just for debugging purpose.
I understand that it should not be there.
> + * - mmu-master: reference to the node of the master device.master device
> + * - mmu-master-compat: 'compatible' proberty of the node of the
> + * of System MMU. This is ignored if @mmu-master is currectlyspecified.> + * - mmu-master-no: instance number of the master device of SystemMMU. This is> + * ignored if @mmu-master is correctly specified. This is '0' bydefault.needed ?
Maybe device node aliases would be better alternative here ? But what
a use case where you can't set 'mmu-master' and 'mmu-master-no' is
It is for platform devices that are not specified in FDT.
Don't we need consider that?